Update Compiler Version Requirements for the OpenACC backend #601
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he OpenACC backend.
JBludau
reviewed
Nov 12, 2024
dalg24
reviewed
Dec 5, 2024
docs/source/requirements.rst
Outdated
| @@ -58,6 +58,10 @@ Kokkos 4.x | |||
| * 22.3 | |||
| * 22.9 | |||
|
|
|||
| * * NVC++ (OpenACC) (experimental) | |||
| * 23.7 | |||
| * 24.5 | |||
There was a problem hiding this comment.
I don't think that is accurate. This column says "primary tested" and we are currently testing with 23.7 in the CI
https://github.com/kokkos/kokkos/blob/cfb48fb7bf1a870a6243125d9cd66cfb0459722c/.jenkins#L185-L196
Are you running nightly builds or such on 24.5?
There was a problem hiding this comment.
I locally use 24.5 to test the OpenACC backend using Kokkos unit tests and other Kokkos benchmarks that I have.
As you said, CI uses 23.7, which is the minimum version that works with the OpenACC backend.
Maybe, I misunderstood what "primary tested" means; I will change the primary tested version to 23.7.
masterleinad
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Compiler Version Requirement document (
requirements.rst) for the OpenACC backend.